Skip to content

Commit

Permalink
Add extra logging to address resolve. (#15653)
Browse files Browse the repository at this point in the history
Logs now look like:

```
CHIP:-: Running chip event loop and waiting for finish...
CHIP:DIS: Node ID resolved for 0x000000000001E1B9
CHIP:DIS:     Addr 0: [fe80::ea68:e7ff:fe31:1684]:5540
CHIP:DIS:     Addr 1: [2607:fea8:1fdf:1001:ea68:e7ff:fe31:1684]:5540
CHIP:DIS:     Addr 2: [10.30.0.157]:5540
CHIP:DIS: Lookup clearing interface for non LL address
CHIP:DIS: UDP:[2607:fea8:1fdf:1001:ea68:e7ff:fe31:1684%enp58s0]:5540:
new best score: 7
CHIP:DIS: UDP:[fe80::ea68:e7ff:fe31:1684%enp58s0]:5540: score has not
improved: 3
CHIP:DIS: UDP:10.30.0.157%enp58s0:5540: score has not improved: 2
CHIP:DIS: Checking node lookup status after 126 ms
CHIP:DIS: Keeping DNSSD lookup active
CHIP:DIS: Discovered node without a pending query
CHIP:DIS: Node ID resolved for 0x000000000001E1B9
CHIP:DIS:     Addr 0: [fe80::ea68:e7ff:fe31:1684]:5540
CHIP:DIS:     Addr 1: [2607:fea8:1fdf:1001:ea68:e7ff:fe31:1684]:5540
CHIP:DIS:     Addr 2: [10.30.0.157]:5540
CHIP:DIS: UDP:[2607:fea8:1fdf:1001:ea68:e7ff:fe31:1684%enp58s0]:5540:
score has not improved: 7
CHIP:DIS: UDP:[fe80::ea68:e7ff:fe31:1684%enp58s0]:5540: score has not
improved: 3
CHIP:DIS: UDP:10.30.0.157%enp58s0:5540: score has not improved: 2
CHIP:DIS: Checking node lookup status after 126 ms
CHIP:DIS: Keeping DNSSD lookup active
```
  • Loading branch information
andy31415 authored and pull[bot] committed Oct 12, 2023
1 parent 3f441cd commit 0fcdcee
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/lib/address_resolve/AddressResolve_DefaultImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,11 @@ void NodeLookupHandle::ResetForLookup(System::Clock::Timestamp now, const NodeLo

void NodeLookupHandle::LookupResult(const ResolveResult & result)
{
#if CHIP_PROGRESS_LOGGING
char addr_string[Transport::PeerAddress::kMaxToStringSize];
result.address.ToString(addr_string);
#endif

unsigned newScore = ScoreValue(ScoreIpAddress(result.address.GetIPAddress(), result.address.GetInterface()));
if (newScore > mBestAddressScore)
{
Expand All @@ -120,9 +125,11 @@ void NodeLookupHandle::LookupResult(const ResolveResult & result)
}

#if CHIP_PROGRESS_LOGGING
char addr_string[Transport::PeerAddress::kMaxToStringSize];
mBestResult.address.ToString(addr_string);
ChipLogProgress(Discovery, "Address %s is scored at %u", addr_string, mBestAddressScore);
ChipLogProgress(Discovery, "%s: new best score: %u", addr_string, mBestAddressScore);
}
else
{
ChipLogProgress(Discovery, "%s: score has not improved: %u", addr_string, newScore);
#endif
}
}
Expand Down

0 comments on commit 0fcdcee

Please sign in to comment.