Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow wifi ssid with spaces #151

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Allow wifi ssid with spaces #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b6b6917
Fix data_model mapped volume
rquidute Sep 18, 2024
6967f46
Allow wifi ssid with spaces
rquidute Oct 3, 2024
f557332
Fix after rebase
rquidute Oct 4, 2024
7bfb4dd
Fix code violation
rquidute Oct 4, 2024
d41fe76
Fix mypy violation
rquidute Oct 4, 2024
9433161
Fix mypy violation
rquidute Oct 4, 2024
0a31410
Fix mypy violation
rquidute Oct 4, 2024
3d4f057
Fix unit test
rquidute Oct 4, 2024
31d453a
Adding back .version_information file
rquidute Oct 4, 2024
4204199
Fix unit test
rquidute Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .version_information
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v2.11-beta3.1+fall2024
v2.11-beta3.1+fall2024
2 changes: 1 addition & 1 deletion test_collections/matter/sdk_tests/support/tests/python_tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ async def test_generate_command_arguments_ble_wifi() -> None:
assert [
"--trace-to json:log",
"--commissioning-method ble-wifi",
"--wifi-ssid testharness",
'--wifi-ssid "testharness"',
"--wifi-passphrase wifi-password",
"--discriminator 147",
"--passcode 357",
Expand Down
6 changes: 5 additions & 1 deletion test_collections/matter/test_environment_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# limitations under the License.
#
from enum import Enum
from typing import Optional, Union
from typing import Any, Optional, Union

from pydantic import BaseModel

Expand All @@ -36,6 +36,10 @@ class WiFiConfig(BaseModel):
ssid: str
password: str

def __init__(self, **kwargs: Any) -> None:
super().__init__(**kwargs)
self.ssid = f'"{self.ssid}"'


class ThreadExternalConfig(BaseModel):
operational_dataset_hex: str
Expand Down
Loading