Skip to content

Commit

Permalink
Changes after code review
Browse files Browse the repository at this point in the history
  • Loading branch information
rquidute committed Nov 13, 2023
1 parent 5872265 commit 8a89c18
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion app/chip_tool/chip_tool.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ def __get_gateway_ip(self) -> str:

async def start_container_no_server(self) -> None:
"""
Creates the chip-tool container without any service running
Creates the chip-tool container without any server running
(ChipTool or ChipApp).
"""
# Ensure there's no existing container running using the same name.
Expand Down
1 change: 0 additions & 1 deletion app/chip_tool/test_case.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ async def setup(self) -> None:
)

self.chip_tool = ChipTool()
await self.chip_tool.start_container_no_server()

# Use test engine logger to log all events to test run.
self.chip_tool.logger = test_engine_logger
Expand Down
5 changes: 1 addition & 4 deletions test_collections/sdk_tests/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,5 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
from .support.python_testing import sdk_python_collection
from .support.yaml_tests import custom_collection, sdk_collection

# TODO The Python test support implementation is ongoing.
# Uncomment line below when the implementation is done.
# from .support.python_testing import sdk_python_collection
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ class SDKPythonTestRunnerHooks(TestRunnerHooks):
is_finished = False
results: Queue

def updates_test(self) -> Union[dict, None]:
def update_test(self) -> Union[dict, None]:
try:
result = self.results.get(block=False)
return result
except Empty:
return None

def finished(self) -> bool:
def is_finished(self) -> bool:

Check failure on line 33 in test_collections/sdk_tests/support/python_testing/models/python_testing_hooks_proxy.py

View workflow job for this annotation

GitHub Actions / Mypy

test_collections/sdk_tests/support/python_testing/models/python_testing_hooks_proxy.py#L33

Name "is_finished" already defined on line 23 [no-redef]
return SDKPythonTestRunnerHooks.is_finished

def __init__(self) -> None:
Expand Down

0 comments on commit 8a89c18

Please sign in to comment.