Return discovered devices that fails to get ip/mac address if ip/mac filters are not used #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…address filters are not used
What this PR does / why we need it:
ref #250
ref #635
Currently, Onvif DH will not return discovered devices if it fails to get devices' ip/mac address. This is not necessary if ip/mac address filter is not used. This PR change Onvif DH so when ip/mac address filter is not used, Onvif DH returns discovered devices no matter it gets ip/mac address from that device (other filters still applied).
When returning discovered devices, Onvif DH does best efforts to retrieve ip/mac address and set to environment variables. If ip/mac address filter is not used, it is possible that ip/mac address environments won't be set (if Onvif DH cannot retrieve ip/mac address from devices).
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)