Ignore no_std feature
#49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
reviewed
Jun 20, 2025
| default = [] | ||
|
|
||
| unstable = [] | ||
| no_std = [] |
There was a problem hiding this comment.
Are you keeping it here because removing it would be a breaking change?
There was a problem hiding this comment.
oh yeah I forgot to mention that! Currently there is no mechanism in place to deprecate feature flags but tbh if we already introduced a major version bump might be worth it to bundle this in too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, using a
no_stdfeature is problematic due to Cargo features needing to be additive, as explicitly mentioned in the linked article.Thankfully, this wasn't a problem a problem in practice, as the
no_stdfeature didn't actually disable any functionality of the crate. For that same reason we can just switch to beingno_stdby default, and link tostdjust for tests.