add various channel mode tests #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Collaborator
Author
|
Unreal also sends an extra parameter for 324 RPL_CHANNELMODEIS: The last parameter is the argument to |
progval
reviewed
Jun 9, 2024
Collaborator
Author
|
The Inspircd fix should be in their 4.0 release, which should be coming soon-ish |
Collaborator
Author
|
@progval I think this is finally done! I updated the Insp stable pointer to |
Collaborator
Author
|
Hmm, Atheme 7.2.12 is incompatible with Insp 4: |
Collaborator
Author
|
Looks like this is blocked: atheme/atheme#904 |
This reverts commit 34534df.
Owner
|
I'll write a PR to add |
Collaborator
Author
|
Looks like we hit a real, but nondeterministic, bug in Sable: Should we turn on backtraces? |
Owner
|
I'll debug it locally |
Owner
|
Oh that was just one of Sable's regular flaky failures. I still don't know how to fix those besides restarting the test. |
progval
reviewed
Jun 15, 2024
Comment on lines
+64
to
+72
| # ERR_NOSUCHNICK is typical, Bahamut additionally sends ERR_USERNOTINCHANNEL | ||
| if self.controller.software_name != "Bahamut": | ||
| self.assertEqual(len(messages), 1) | ||
| self.assertMessageMatch(messages[0], command=ERR_NOSUCHNICK) | ||
| else: | ||
| self.assertLessEqual(len(messages), 2) | ||
| commands = {message.command for message in messages} | ||
| self.assertLessEqual({ERR_NOSUCHNICK}, commands) | ||
| self.assertLessEqual(commands, {ERR_NOSUCHNICK, ERR_USERNOTINCHANNEL}) |
Comment on lines
+82
to
+88
| # Modern: "If <target> is a channel that does not exist on the network, | ||
| # the ERR_NOSUCHCHANNEL (403) numeric is returned." | ||
| # However, Unreal and ngircd send 401 ERR_NOSUCHNICK here instead: | ||
| if self.controller.software_name not in ("UnrealIRCd", "ngIRCd"): | ||
| self.assertEqual(messages[0].command, ERR_NOSUCHCHANNEL) | ||
| else: | ||
| self.assertIn(messages[0].command, [ERR_NOSUCHCHANNEL, ERR_NOSUCHNICK]) |
Owner
There was a problem hiding this comment.
progval
added
the
blocked by: implementation
Co-authored-by: Val Lorentz <progval+github@progval.net>
Contributor
This will also be in our next v3 release which comes out the Friday after next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked for Ergo by ergochat/ergo#2163 but I wanted to see what the state of play is with other ircds