Skip to content

Remove 'inline' from the destructor#53

Open
ghost wants to merge 1 commit intomasterfrom
unknown repository
Open

Remove 'inline' from the destructor#53
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Feb 9, 2018

When compiling with GCC using -Winline the compiler warns that the call to the destructor will not be inlined (I use ThreadPool in multiple places):

ThreadPool/ThreadPool.h:87:8: warning: inlining failed in call to 
‘ThreadPool::~ThreadPool() noexcept’: call is unlikely and code size would grow [-Winline]
 inline ThreadPool::~ThreadPool()

Besides, there is no reason in inline here. Removing it.

@jhasse
Copy link

jhasse commented Apr 18, 2018

I hope you're okay with that I cherry-picked your commit on my fork: jhasse@5c54162 :)

@ghost
Copy link
Author

ghost commented Apr 18, 2018

Sure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant