Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust if-loops for lesson-testers and tested-date #3536

Open
wants to merge 19 commits into
base: gh-pages
Choose a base branch
from

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Apr 11, 2025

  • Updating lessons that feature lesson_testers (the name of the tester doesn't display) with lesson-testers
  • Replacing tested_date with tested-date for consistency
  • Updating the loop in _layouts/lesson.html so that it searches for tested-date (hyphen) rather than tested_date (underscore)

N.B. snippets.yml is searching for hyphens in both

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Replace underscore with hyphen
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
Underscore > hyphen (`tested-date:`)
@anisa-hawes anisa-hawes self-assigned this Apr 11, 2025
@anisa-hawes anisa-hawes changed the title Adjust if loops tested testers Adjust if-loops for lesson-testers and tested-date Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant