Skip to content

Conversation

ZoeLeBlanc
Copy link
Member

@ZoeLeBlanc ZoeLeBlanc commented Sep 1, 2021

This PR slightly shifts PT color for accessibility contrast (thanks @walshbr for doing all the hard work on this one) and also closes #2072 with the remaining accessibility audit issues being temporarily archived until we start rebuilding the site infrastructure.

Checklist

  • Assign yourself in the "Assignees" menu
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing edtor in your PR. Please follow the translation request guidelines when writing your PR description
  • Add the appropriate "Label"
  • Ensure the status checks pass
  • Check the live preview of your PR on Netlify
  • If this PR closes an open issue, add the phrase Closes #ISSUENUMBER to the description above

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

@ZoeLeBlanc ZoeLeBlanc requested a review from a team September 1, 2021 01:43
@ZoeLeBlanc ZoeLeBlanc self-assigned this Sep 1, 2021
@jenniferisasi
Copy link
Contributor

jenniferisasi commented Sep 14, 2021

Screen Shot 2021-09-14 at 3 41 08 PM

How do we change the color of the "sticker"?

@ZoeLeBlanc
Copy link
Member Author

Ohh darn just looking at this now and realizing that I made the sticker in Photoshop, so think I'm gonna have to track down this file and update it 😅. I'll try to get to that this week!

@ZoeLeBlanc
Copy link
Member Author

Small update but I'm in the process of switching computers and switching my adobe account. If anyone has access to photoshop I can likely share the original file for the color tweaking, but I'll need likely two more weeks to get to this since I have to setup the new laptop from scratch 😭 .

@DanielAlvesLABDH
Copy link
Contributor

Dear @ZoeLeBlanc could you send me the file? I think I can make the change with the help of a colleague here in Lisbon. Thanks!

@rivaquiroga
Copy link
Member

@ZoeLeBlanc, is this file, right? https://github.com/programminghistorian/jekyll/blob/pt-color-change/images/logos/ph-pt.svg

@rivaquiroga
Copy link
Member

I left a version with the new color in this brach in case that was the file: https://github.com/programminghistorian/jekyll/tree/pt-logo-background/images/logos

@ZoeLeBlanc
Copy link
Member Author

Thanks for this @rivaquiroga ! I did have the original photoshop file somewhere but I can't find it, so I think that svg is our best bet. Also looks like you maybe already did this fix? If yes then extra thank yous 🙏🏽 and feel free to push up into this PR or create a new one 👍🏽

Copy link
Contributor

@DanielAlvesLABDH DanielAlvesLABDH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @rivaquiroga

@rivaquiroga
Copy link
Member

I just pushed the changes to this branch. Looks good now.

@DanielAlvesLABDH
Copy link
Contributor

Hello @ZoeLeBlanc! Can we merge this?

@ZoeLeBlanc
Copy link
Member Author

ZoeLeBlanc commented Oct 23, 2021

Looks great to me@DanielAlvesLABDH 👍🏽 (I can't approve officially because I opened this PR 😅 ) but I"ll go ahead and merge it in!

@ZoeLeBlanc ZoeLeBlanc merged commit 0d23a56 into gh-pages Oct 23, 2021
@ZoeLeBlanc ZoeLeBlanc deleted the pt-color-change branch October 23, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility Audit

5 participants