-
Notifications
You must be signed in to change notification settings - Fork 229
Pt color change #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pt color change #2250
Conversation
Ohh darn just looking at this now and realizing that I made the sticker in Photoshop, so think I'm gonna have to track down this file and update it 😅. I'll try to get to that this week! |
Small update but I'm in the process of switching computers and switching my adobe account. If anyone has access to photoshop I can likely share the original file for the color tweaking, but I'll need likely two more weeks to get to this since I have to setup the new laptop from scratch 😭 . |
Dear @ZoeLeBlanc could you send me the file? I think I can make the change with the help of a colleague here in Lisbon. Thanks! |
I left a version with the new color in this brach in case that was the file: https://github.com/programminghistorian/jekyll/tree/pt-logo-background/images/logos |
Thanks for this @rivaquiroga ! I did have the original photoshop file somewhere but I can't find it, so I think that svg is our best bet. Also looks like you maybe already did this fix? If yes then extra thank yous 🙏🏽 and feel free to push up into this PR or create a new one 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @rivaquiroga
I just pushed the changes to this branch. Looks good now. |
Hello @ZoeLeBlanc! Can we merge this? |
Looks great to me@DanielAlvesLABDH 👍🏽 (I can't approve officially because I opened this PR 😅 ) but I"ll go ahead and merge it in! |
This PR slightly shifts PT color for accessibility contrast (thanks @walshbr for doing all the hard work on this one) and also closes #2072 with the remaining accessibility audit issues being temporarily archived until we start rebuilding the site infrastructure.
Checklist
Closes #ISSUENUMBER
to the description aboveIf you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.