Skip to content

Added support for blank columns, empty typed rows and pointers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 12, 2021
Merged

Added support for blank columns, empty typed rows and pointers #2

merged 9 commits into from
Jul 12, 2021

Conversation

@leonsteinhaeuser
Copy link
Contributor

This PR adds support for empty columns and rows (rows only for typed data)

@leonsteinhaeuser leonsteinhaeuser added bug fix Indicates that this change contains bug fixes enhancement New feature or request size: M Size M indicates that the changes affect less then 500 lines of code. labels Jul 7, 2021
@leonsteinhaeuser leonsteinhaeuser self-assigned this Jul 7, 2021
@leonsteinhaeuser leonsteinhaeuser changed the title Added support for blank columns and empty type rows Added support for blank columns and empty typed rows Jul 7, 2021
@leonsteinhaeuser leonsteinhaeuser changed the title Added support for blank columns and empty typed rows Added support for blank columns, empty typed rows and pointers Jul 9, 2021
@leonsteinhaeuser leonsteinhaeuser marked this pull request as ready for review July 9, 2021 11:37
@leonsteinhaeuser leonsteinhaeuser added size: L Size L indicates that the changes affect less then 1000 lines of code. and removed size: M Size M indicates that the changes affect less then 500 lines of code. labels Jul 9, 2021
martinrode
martinrode requested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@martinrode martinrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Initialize CSV with CSVParser{}.
  • Make all options capitalized.
  • Sort all exported function to the top
  • export "Typed()", "Untyped()" (renamed from ToTypedMap, ToUntypedMap)

@martinrode
json: improved type when using "*json"
a09fd29 
We no longer return &interface{} as type when using *json, but instead we maintain the actual type of the JSON (as created by unmarshal) and return a pointer to it.
@martinrode
Renamed CSV to CSVParser
3169c80
@martinrode martinrode merged commit 252899e into main Jul 12, 2021
@martinrode martinrode deleted the enhancement/csv-empty-columns-and-rows branch July 12, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinrode martinrode martinrode approved these changes

Assignees

@leonsteinhaeuser leonsteinhaeuser

Labels

bug fix Indicates that this change contains bug fixes enhancement New feature or request size: L Size L indicates that the changes affect less then 1000 lines of code.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leonsteinhaeuser @martinrode