Skip to content

removed and ignored Gemfile.lock #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2016
Merged

removed and ignored Gemfile.lock #684

merged 1 commit into from
Dec 1, 2016

Conversation

aollier
Copy link
Contributor

@aollier aollier commented Dec 1, 2016

It is unnecessary to track Gemfile.lock because it is platform dependant and it causes problems to build the book.

For example, on my computer under Fedora 25, I had to make a new Gemfile.lock to be able to build the book. So the differences are important :

diff --git a/Gemfile.lock b/Gemfile.lock
index 422295d..294e941 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -15,27 +15,27 @@ GEM
       prawn-table (= 0.1.1)
       prawn-templates (= 0.0.3)
       treetop (= 1.5.3)
-    awesome_print (1.2.0)
-    coderay (1.1.0)
+    awesome_print (1.7.0)
+    coderay (1.1.1)
     epubcheck (3.0.1)
     gepub (0.6.9.2)
       nokogiri (~> 1.6.1)
       rubyzip (>= 1.1.1)
-    hashery (2.1.1)
-    json (1.8.3)
-    kindlegen (2.9.4)
-    mini_portile (0.6.0)
-    nokogiri (1.6.3.1)
-      mini_portile (= 0.6.0)
+    hashery (2.1.2)
+    json (2.0.2)
+    kindlegen (2.9.7)
+    mini_portile2 (2.1.0)
+    nokogiri (1.6.8.1)
+      mini_portile2 (~> 2.1.0)
     pdf-core (0.2.5)
-    pdf-reader (1.3.3)
+    pdf-reader (1.4.0)
       Ascii85 (~> 1.0.0)
-      afm (~> 0.2.0)
+      afm (~> 0.2.1)
       hashery (~> 2.0)
       ruby-rc4
       ttfunk
     polyglot (0.3.5)
-    posix-spawn (0.3.9)
+    posix-spawn (0.3.12)
     prawn (1.2.1)
       pdf-core (~> 0.2.5)
       ttfunk (~> 1.2.0)
@@ -45,17 +45,17 @@ GEM
     prawn-templates (0.0.3)
       pdf-reader (~> 1.3)
       prawn (>= 0.15.0)
-    pygments.rb (0.6.0)
+    pygments.rb (0.6.3)
       posix-spawn (~> 0.3.6)
-      yajl-ruby (~> 1.1.0)
-    rake (10.3.2)
+      yajl-ruby (~> 1.2.0)
+    rake (11.3.0)
     ruby-rc4 (0.1.5)
-    rubyzip (1.1.6)
-    thread_safe (0.3.4)
+    rubyzip (1.2.0)
+    thread_safe (0.3.5)
     treetop (1.5.3)
       polyglot (~> 0.3)
     ttfunk (1.2.2)
-    yajl-ruby (1.1.0)
+    yajl-ruby (1.2.1)
 
 PLATFORMS
   ruby
@@ -72,3 +72,6 @@ DEPENDENCIES
   pygments.rb
   rake
   thread_safe
+
+BUNDLED WITH
+   1.11.2

It is unnecessary to track Gemfile.lock because it is platform dependant and it causes problems to build the book.
@ben
Copy link
Member

ben commented Dec 1, 2016

Good point, you're probably right in this instance. Thanks!

@ben ben merged commit 3ae4705 into progit:master Dec 1, 2016
@jnavila
Copy link
Member

jnavila commented Dec 1, 2016

Well, the Gemfile.lock is supposed to insure a known-good combination of packages. But, right now, this leads to compilation errors indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants