Fix hex/dec error

[tacker66]

Signed-off-by: Thomas Ackermann th.acker@arcor.de

[schacon]

I can see how this is unclear.

By "005b, which is 91 in hex" we mean "005b, which is the hexadecimal representation of 91". The "in hex" is supposed to explain '005b', not '91'. Changing this word I think makes things confusing in the other direction. If you change this PR to "which is the hexadecimal representation of 91" instead I think it would be worth merging. Thoughts @ben?

[ben]

Your first line starts with 005b, which is hexadecimal for 91, meaning that 91 bytes remain on that line.

[tacker66]

I changed the pull request to @ben's suggestion but what about dropping the "which is hexadecimal for 91" altogether because we are not doing a primer on number systems here?

[schacon]

I'm not sure how removing the explanation of the number makes it clearer. We're not even explaining what hexadecimal is, we're simply explaining why that string means 91. It's not like we're going into an explanation of number bases. Saying that it's hex instead of octal even is at least minimally helpful because it doesn't require the reader to work backwards to figure out the base.

I think simplifying the sentence to Ben's suggestion is probably the overall best course here.

[tacker66]

Agreed 👍

[ben]

Nice. Thanks!