Migrate to Asciidoctor 2.0.11#1554
Merged
jnavila merged 1 commit intoprogit:masterfrom Nov 6, 2020
HonkingGoose:migration-asciidoctor-2.0.11
Merged
Migrate to Asciidoctor 2.0.11#1554jnavila merged 1 commit intoprogit:masterfrom HonkingGoose:migration-asciidoctor-2.0.11
jnavila merged 1 commit intoprogit:masterfrom
HonkingGoose:migration-asciidoctor-2.0.11
Conversation
- Bump Asciidoctor from 1.5.6.2 to 2.0.11 - Change style to new specifications. - Pin dependencies - Fix unintended highlighting of text - Undo rake script on Markdown file - Undo rake script on Ruby file Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Contributor
Author
|
I've squashed the changes that I and @jnavila made on #1373, and also merged #1541 into this branch. I manually migrated some missing legacy double quoted syntax to the modern syntax. I think this is ready to go, but @jnavila can you please run that migration script again on this branch, and see what it catches? @ben can you take a look at this and tell me what you think of it? |
ben
approved these changes
Nov 3, 2020
Member
ben
left a comment
ben
left a comment
There was a problem hiding this comment.
LGTM 👍 You may merge when ready. 😁
Member
|
This was mostly a quoting issue. So OK for me. |
Contributor
Author
|
Woohoo! 🥳 🎈 🎆 ✨ |
Contributor
Author
|
By the way the project board that @jnavila made on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
Fixes #1553
Fixes #1541
Fixes #1358
Fixes #1373