Check RHS string container definition against class_exist() first #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, there are some errors in static analysis (phpstan). Do you think you will be able to fix them? |
|
Note that these errors are present in previous commit https://github.com/proget-hq/phpstan-yii2/runs/1750059336 |
marmichalski
force-pushed
the
container-rhs-string
branch
from
3dc55e1 to
5e36c21
Compare
marmichalski
force-pushed
the
container-rhs-string
branch
from
344c93b to
e882406
Compare
|
Thanks! 🌹 |
|
Thank you too. Do you consider to issue a release to allow get it by tag from composer? |
|
It has been tagged just about now: https://github.com/proget-hq/phpstan-yii2/releases/tag/0.7.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37