Skip to content

Advertise support for PHP 8.0 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

EtienneBruines
Copy link
Contributor

@EtienneBruines EtienneBruines commented Dec 2, 2020

When actually installing this on PHP 8.0, it still cannot due to php-cs-fixer. But, that's out-of-scope for this phpstan-yii2 project, meaning that this project is actually compatible.

  Problem 1
    - friendsofphp/php-cs-fixer is locked to version v2.16.7 and an update of this package was not requested.
    - friendsofphp/php-cs-fixer v2.16.7 requires php ^7.1 -> your php version (8.0.0) does not satisfy that requirement.

Composer will automatically allow installing it then, once php-cs-fixer has been updated as well.

@EtienneBruines
Copy link
Contributor Author

How do we bring composer.lock up-to-date in this repo?

  Problem 1
    - yiisoft/yii2[2.0.15, ..., 2.0.15.1] require bower-asset/jquery 3.2.*@stable | 3.1.*@stable | 2.2.*@stable | 2.1.*@stable | 1.11.*@stable | 1.12.*@stable -> found bower-asset/jquery[3.5.1] but it does not match the constraint.
    - yiisoft/yii2[2.0.16, ..., 2.0.18] require bower-asset/jquery 3.3.*@stable | 3.2.*@stable | 3.1.*@stable | 2.2.*@stable | 2.1.*@stable | 1.11.*@stable | 1.12.*@stable -> found bower-asset/jquery[3.5.1] but it does not match the constraint.
    - yiisoft/yii2[2.0.19, ..., 2.0.35] require bower-asset/jquery 3.4.*@stable | 3.3.*@stable | 3.2.*@stable | 3.1.*@stable | 2.2.*@stable | 2.1.*@stable | 1.11.*@stable | 1.12.*@stable -> found bower-asset/jquery[3.5.1] but it does not match the constraint.
    - yiisoft/yii2[2.0.36, ..., 2.0.39.3] require bower-asset/jquery 3.5.*@stable | 3.4.*@stable | 3.3.*@stable | 3.2.*@stable | 3.1.*@stable | 2.2.*@stable | 2.1.*@stable | 1.11.*@stable | 1.12.*@stable -> found bower-asset/jquery[3.5.1] in lock file but not in remote repositories, make sure you avoid updating this package to keep the one from lock file.
    - Root composer.json requires yiisoft/yii2 ^2.0.15 -> satisfiable by yiisoft/yii2[2.0.15, ..., 2.0.39.3].

@EtienneBruines
Copy link
Contributor Author

@marmichalski @akondas anything I can do to help this project?

@akondas
Copy link
Contributor

akondas commented Jan 22, 2021

You can try to run composer update --lock

@EtienneBruines
Copy link
Contributor Author

EtienneBruines commented Jan 22, 2021

Thank you for your reply.

That requires composer to have access to bower-asset, which is currently not defined in the composer.json file. See #35 (comment)

Could we add this to the composer.json file?

"repositories": [
    {
        "type": "composer",
        "url": "https://asset-packagist.org"
    }
]

@EtienneBruines EtienneBruines force-pushed the patch-2 branch 4 times, most recently from 313258a to 7945844 Compare January 22, 2021 10:19
Updated all dependencies to latest version.
@EtienneBruines
Copy link
Contributor Author

@akondas that would then result in the current commit.

@akondas akondas requested a review from marmichalski January 22, 2021 10:52
Copy link
Contributor

@akondas akondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marmichalski marmichalski merged commit bf8194f into proget-hq:master Jan 22, 2021
@marmichalski
Copy link
Contributor

Thanks 🥰

@akondas
Copy link
Contributor

akondas commented Jan 23, 2021

New release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants