Skip to content

Fixed notice for undefined-index #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Sep 12, 2019
Merged

Fixed notice for undefined-index #18

1 commit merged into from
Sep 12, 2019

Conversation

EtienneBruines
Copy link
Contributor

Without this bugfix, under PHP 7.3.9 with notices enabled, the following is outputted:

$ composer stan

PHP Notice:  Undefined index: request in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: request in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: response in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: response in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: user in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77
PHP Notice:  Undefined index: user in /home/e.bruines00000/workspaces/phpstan-yii2/src/ServiceMap.php on line 77

@EtienneBruines EtienneBruines force-pushed the bugfix-undefined-index branch 3 times, most recently from 35f09a0 to 17e24c4 Compare September 11, 2019 15:02
@EtienneBruines
Copy link
Contributor Author

@akondas @marmichalski this PR seems important before the release version 0.6.0.

@ghost
Copy link

ghost commented Sep 12, 2019

Thanks ❤️

@ghost ghost merged commit 2ce1dcd into proget-hq:master Sep 12, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EtienneBruines