Fix/tests/cleanup #72
Conversation
aensidhe
commented
Oct 26, 2016
aensidhe
commented
- Fix tests to be deterministic
- Fix error in EVAL semantic
- Fix error in CALL semantic
- Implement CALL 1.7 semantic
- Handle nulls in response
…ts via the instance Connect and ConnectAsync methods` on Linux
| { | ||
| var hashCode = EqualityComparer<T1>.Default.GetHashCode(Item1); | ||
| return hashCode; | ||
| unchecked |
There was a problem hiding this comment.
Do we really need unchecked{} section here?
What about other TarantoolTuple classes (<T1,T2> and so on)?
There was a problem hiding this comment.
@roman-kozachenko in this class - no we do not need. But we need it in other classes. So, as this code is autogenerated, I will not edit it.
There was a problem hiding this comment.
@aensidhe Actually I already found that, forgot to remove comment
| var singleNode = options.ConnectionOptions.Nodes.Single(); | ||
|
|
||
| _socket = new Socket(SocketType.Stream, ProtocolType.Tcp); | ||
| #if PROGAUDI_NETCORE |
There was a problem hiding this comment.
Looks like you don't need that #if anymore.
| box.once('init', init) | ||
| function return_scalar() | ||
| return 1 | ||
| end |
There was a problem hiding this comment.
Did you test what happens when you call a function without return statement?
There was a problem hiding this comment.
@roman-kozachenko ok. I added tests and separate overload for call for this
| if (_clientOptions.LogWriter == null) | ||
| return; | ||
|
|
||
| var builder = new StringBuilder("Warning: can't match request via requestId from response. Response:"); |
There was a problem hiding this comment.
Extract to separate method
