Skip to content

Conversation

@barbieri
Copy link
Member

Features:

  • httpx support (Client + AsyncClient), thanks @kewisch

Chore:

  • update pyproject.toml structure
  • graphql-core from 3.2.4 to 3.2.6 (~=)
  • indirect dependencies updated to latest versions
  • pre-commit hooks updated to latest versions

@coveralls
Copy link

coveralls commented Aug 27, 2025

Pull Request Test Coverage Report for Build 17269623697

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 17268212957: 0.0%
Covered Lines: 1687
Relevant Lines: 1687

💛 - Coveralls

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the project version from 16.5 to 17, introducing HTTPx support for both synchronous and asynchronous clients while improving code quality and test robustness.

  • Version update across all configuration files and documentation
  • Test improvements with proper assertion operators and more realistic HTTP response mocking
  • Documentation corrections for HTTPx endpoint usage and docstring typos

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sgqlc/init.py Version bump to 17
pyproject.toml Version update and pytest asyncio configuration
doc/source/conf.py Documentation version update
README.rst Fix incorrect class name in HTTPx async example
sgqlc/endpoint/httpx.py Spelling corrections in docstrings
tests/test-endpoint-httpx.py Improved test assertions and more realistic HTTP response mocking
tests/test-endpoint-http.py Fixed assertion operators from comma to equality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 519 to 523
exp_exc = None
try:
res.raise_for_status()
except httpx.HTTPStatusError as e:
exp_exc = e
Copy link

Copilot AI Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable exp_exc is initialized as None but will always be assigned an exception since res.raise_for_status() will always raise for a 500 status code. Consider removing the initialization or adding a comment explaining why this pattern is used.

Copilot uses AI. Check for mistakes.
@barbieri barbieri closed this Aug 27, 2025
@barbieri barbieri deleted the release-v17 branch August 27, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants