Skip to content

Implement 1Password secret provider CLI operations - #168

Closed
Robertg761 wants to merge 1 commit into
profullstack:masterfrom
Robertg761:codex/secrets-onepassword-cli
Closed

Robertg761 wants to merge 1 commit into
profullstack:masterfrom
Robertg761:codex/secrets-onepassword-cli

Conversation

@Robertg761

Copy link
Copy Markdown

Related to #6 and #133.

This upgrades secrets-onepassword from log-only stubs to real 1Password CLI-backed secret pull/push behavior.

What changed:

  • verify the signed-in account path with op whoami --format json during connect
  • implement pull via op item get <item> --vault <vault> --format json
  • map 1Password item fields into sh1pt SecretRef[] values with vault/item metadata
  • implement push via op item edit <item> --vault <vault> KEY=value ...
  • require config.item for pull/push so commands do not silently target a placeholder
  • add mocked-CLI tests for pull, push, connect, and missing item behavior

Verified:

  • pnpm exec vitest run packages/secrets/onepassword/src/index.test.ts
  • pnpm --filter @profullstack/sh1pt-secrets-onepassword typecheck
  • pnpm --filter @profullstack/sh1pt typecheck
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant