Repository navigation
Implement 1Password secret provider CLI operations - #168
Closed
Robertg761 wants to merge 1 commit into
Closed
Robertg761 wants to merge 1 commit into
Robertg761 wants to merge 1 commit into
Conversation
This was referenced May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #6 and #133.
This upgrades
secrets-onepasswordfrom log-only stubs to real 1Password CLI-backed secret pull/push behavior.What changed:
op whoami --format jsonduring connectpullviaop item get <item> --vault <vault> --format jsonSecretRef[]values with vault/item metadatapushviaop item edit <item> --vault <vault> KEY=value ...config.itemfor pull/push so commands do not silently target a placeholderVerified:
pnpm exec vitest run packages/secrets/onepassword/src/index.test.tspnpm --filter @profullstack/sh1pt-secrets-onepassword typecheckpnpm --filter @profullstack/sh1pt typecheckgit diff --check