Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix ci pipeline view incorrect timestamp being used #864

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

junderhill
Copy link

@junderhill junderhill commented Oct 6, 2021

Fixes #858

Description

Update the property used for printing the pipeline created at time within the pipeline ci view command

How Has This Been Tested?

Compiled the code and tested against my own GitLab instance/pipelines.
Initiated a new pipeline from a commit that was made hours ago and verified the result.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@junderhill
Copy link
Author

Noted the linting and code analysis check failures above - non of my changes are responsible for these I believe.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @junderhill!

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #864 (b7d7be1) into trunk (3d9f97c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #864   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files          93       93           
  Lines        7383     7383           
=======================================
  Hits         4379     4379           
  Misses       2619     2619           
  Partials      385      385           
Impacted Files Coverage Δ
commands/ci/view/view.go 48.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9f97c...b7d7be1. Read the comment docs.

@profclems profclems merged commit 2e4c14b into profclems:trunk Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipeline view showing incorrect triggered timestamp
2 participants