Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix: :id placeholder in api command #742

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

profclems
Copy link
Owner

@profclems profclems commented May 27, 2021

Using :id placeholder in api command fails with Project Not Found.
This is caused by directly converting the int to rune before converting to string producing an ascii character ()

This PR fixes this issue.

Related to #657 #663

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #742 (9f21660) into trunk (a18cc9f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #742   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files          93       93           
  Lines        6663     6663           
=======================================
  Hits         3905     3905           
  Misses       2379     2379           
  Partials      379      379           
Impacted Files Coverage Δ
commands/api/api.go 74.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18cc9f...9f21660. Read the comment docs.

@profclems profclems merged commit cd37ff9 into trunk May 27, 2021
@profclems profclems deleted the fix-id-placeholder-api branch May 27, 2021 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant