linting

profclems · May 25, 2021 · c99798a · c99798a
1 parent 42a7d4c
commit c99798a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/commands/release/list/release_list.go b/commands/release/list/release_list.go
@@ -30,10 +30,12 @@ func NewCmdReleaseList(f *cmdutils.Factory) *cobra.Command {
 	}
 	releaseListCmd.Flags().StringP("tag", "t", "", "Filter releases by tag <name>")
 	// deprecate in favour of the `release view` command
-	releaseListCmd.Flags().MarkDeprecated("tag", "use `glab release view <tag>` instead")
+	_ = releaseListCmd.Flags().MarkDeprecated("tag", "use `glab release view <tag>` instead")
+
 	// make it hidden but still accessible
 	// TODO: completely remove before a major release (v2.0.0+)
-	releaseListCmd.Flags().MarkHidden("tag")
+	_ = releaseListCmd.Flags().MarkHidden("tag")
+
 	return releaseListCmd
 }
 

diff --git a/commands/release/releaseutils/releaseutils.go b/commands/release/releaseutils/releaseutils.go
@@ -32,7 +32,7 @@ func RenderReleaseAssertLinks(assets []*gitlab.ReleaseLink) string {
 	}
 	t := tableprinter.NewTablePrinter()
 	for _, asset := range assets {
-		t.AddRow(asset.Name, asset.LinkType, asset.DirectAssetURL)
+		t.AddRow(asset.Name, asset.DirectAssetURL)
 		//assetsPrint += asset.DirectAssetURL + "\n"
 	}
 	return t.String()

diff --git a/commands/release/view/view.go b/commands/release/view/view.go
@@ -2,6 +2,7 @@ package view
 
 import (
 	"fmt"
+
 	"github.com/MakeNowJust/heredoc"
 	"github.com/profclems/glab/commands/cmdutils"
 	"github.com/profclems/glab/commands/release/releaseutils"
@@ -15,7 +16,7 @@ import (
 )
 
 type ViewOpts struct {
-	TagName     string
+	TagName       string
 	OpenInBrowser bool
 
 	IO         *iostreams.IOStreams
@@ -84,7 +85,7 @@ func deleteRun(opts *ViewOpts) error {
 	if opts.TagName == "" {
 		tags, resp, err := client.Tags.ListTags(repo.FullName(), &gitlab.ListTagsOptions{
 			OrderBy: gitlab.String("updated"),
-			Sort: gitlab.String("desc"),
+			Sort:    gitlab.String("desc"),
 		})
 		if err != nil && resp != nil && resp.StatusCode != 404 {
 			return cmdutils.WrapError(err, "could not fetch tag")
@@ -109,7 +110,7 @@ func deleteRun(opts *ViewOpts) error {
 			repo.FullName(), release.TagName)
 
 		if opts.IO.IsOutputTTY() {
-			opts.IO.Logf("Opening %s in your browser.\n", release)
+			opts.IO.Logf("Opening %s in your browser.\n", url)
 		}
 
 		browser, _ := cfg.Get(repo.RepoHost(), "browser")