Skip to content

Commit

Permalink
ci: remove components-repo-ci blocklist (angular#35115)
Browse files Browse the repository at this point in the history
Previously we needed the `components-repo-ci` blocklist to disable
tests that were failing during the development of Ivy. Since we fixed
all those failing tests, and we don't want to regress, we can remove the
blocklist logic.

Resolves FW-1807

PR Close angular#35115
  • Loading branch information
devversion authored and mhevery committed Feb 6, 2020
1 parent 10ad984 commit c4ad12c
Showing 4 changed files with 1 addition and 87 deletions.
20 changes: 0 additions & 20 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
@@ -978,26 +978,6 @@ groups:
- ~framework-global-approvers


# =========================================================
# Material CI
# =========================================================
material-ci:
conditions:
- >
contains_any_globs(files, [
'tools/components-repo-ci/**'
])
reviewers:
users:
- alxhub
- AndrewKushnir
- kara
- mhevery
- pkozlowski-opensource
teams:
- ~framework-global-approvers


# =========================================================
# Public API
# =========================================================
7 changes: 1 addition & 6 deletions scripts/ci/run_angular_components_unit_tests.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#!/usr/bin/env bash
set -u -e -o pipefail

# Script that runs all unit tests of the `angular/components` repository. The script also
# sets up the test blocklist from `tools/components-repo-ci`.
# Script that runs all unit tests of the `angular/components` repository.

# Path to the Angular project.
angular_dir=$(pwd)
@@ -11,10 +10,6 @@ angular_dir=$(pwd)
# repository has been cloned into.
cd ${COMPONENTS_REPO_TMP_DIR}

# Copy the test blocklist into the `angular/components` repository. The unit tests will
# automatically pick up the blocklist and disable the specified tests.
cp ${angular_dir}/tools/components-repo-ci/test-blocklist.ts ${COMPONENTS_REPO_TMP_DIR}/test/

# Create a symlink for the Bazel binary installed through NPM, as running through Yarn introduces OOM errors.
./scripts/circleci/setup_bazel_binary.sh

32 changes: 0 additions & 32 deletions tools/components-repo-ci/instructions.md

This file was deleted.

29 changes: 0 additions & 29 deletions tools/components-repo-ci/test-blocklist.ts

This file was deleted.

0 comments on commit c4ad12c

Please sign in to comment.