Skip to content

Commit

Permalink
ci: temporarily disable payload size tracking (angular#31057)
Browse files Browse the repository at this point in the history
The `CIRCLE_COMPARE_URL` is not available in builds any more since we
enabled `Pipelines` on CircleCI. We have contected CircleCI, but until
this is solved we cannot get the commit range and thus disabling
uploading of payload size data to avoid broken builds.

PR Close angular#31057
  • Loading branch information
gkalpak authored and AndrewKushnir committed Jun 14, 2019
1 parent 1a5c711 commit 48d11d5
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions scripts/ci/payload-size.sh
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,17 @@ trackPayloadSize() {
# Save the file sizes to be retrieved from `payload-size.js`.
echo "$(payloadToJson)" > /tmp/current.log

# TODO: Temporarily disabled until we get back `CIRCLE_COMPARE_URL` or another way to get the
# commit range. Re-enable once the issue is resolved.
# If this is a non-PR build, upload the data to firebase.
if [[ "$CI_PULL_REQUEST" == "false" ]]; then
if [[ $trackChangeType = true ]]; then
addChangeType $CI_COMMIT_RANGE
fi
addTimestamp
addMessage $CI_COMMIT_RANGE
uploadData $name
fi
# if [[ "$CI_PULL_REQUEST" == "false" ]]; then
# if [[ $trackChangeType = true ]]; then
# addChangeType $CI_COMMIT_RANGE
# fi
# addTimestamp
# addMessage $CI_COMMIT_RANGE
# uploadData $name
# fi

# Check the file sizes against the specified limits.
if [[ $checkSize = true ]]; then
Expand Down

0 comments on commit 48d11d5

Please sign in to comment.