Skip to content

Commit

Permalink
refactor(platform-browser): specify return type of parseEventName (an…
Browse files Browse the repository at this point in the history
…gular#38089)

This commit refactors the argument of the `parseEventName` function
to use an object with named properties instead of using an object indexer.

PR Close angular#38089
  • Loading branch information
sonukapoor authored and mhevery committed Jul 27, 2020
1 parent 5d3ba8d commit 174aac6
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions packages/platform-browser/src/dom/events/key_events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export class KeyEventsPlugin extends EventManagerPlugin {
});
}

static parseEventName(eventName: string): {[key: string]: string}|null {
static parseEventName(eventName: string): {fullKey: string, domEventName: string}|null {
const parts: string[] = eventName.toLowerCase().split('.');

const domEventName = parts.shift();
Expand All @@ -136,10 +136,7 @@ export class KeyEventsPlugin extends EventManagerPlugin {
return null;
}

const result: {[k: string]: string} = {};
result['domEventName'] = domEventName;
result['fullKey'] = fullKey;
return result;
return {domEventName, fullKey};
}

static getEventFullKey(event: KeyboardEvent): string {
Expand Down

0 comments on commit 174aac6

Please sign in to comment.