Loading dirty-chai before chai-jquery breaks empty()

[justin-lau]

The readme stated that dirty-chai should be loaded before any other plugins, but I found that if I load dirty-chai before chai-jquery, a should.be.empty() throws a TypeError: empty is not a function.

However, if I load chai-jquery before dirty-chai, the said problem is gone, and what's more, the property assertions in chai-jquery actually convert to method assertions.

[astorije]

FWIW, while using the chai-immutable plugin, @iensu noticed the similar requirement: astorije/chai-immutable#57.

[joshperry]

Sorry guys, dirty-chai does hook the internal methods that plugins use to extend chai in order to convert assertions to methods. I do have an outstanding PR with tests that work a problem with a similar issue to this. Perhaps the guidance should just be changed to run dirty-chai last instead of first.

Hopefully this will get less hairy with extendable assertion formats that are supposed to come in a newer chai. I'll be tracking this in #7.

[adamcohen]

I'm running into the same issue with chai-fs, although I can't fix the TypeError: expect(...).to.be.empty is not a function error regardless of the order.

I've tried every permutation of the following lines, but nothing works:

const chaiFS = require('chai-fs')
const dirtyChai = require('dirty-chai')

chai.use(dirtyChai)
chai.use(chaiFS)

It seems that once you use chai.use(chaiFS) in one of your tests, any other test that uses to.be.empty() will fail.

I've gotten around this by using the property form of empty instead of the function form, and just disabling the eslint rule wherever I do this, but it's far from ideal:

// eslint-disable-next-line no-unused-expressions
 expect(subject).to.be.empty