Conversation
Basic build and test running via CMake and CTest.
These dependencies will be forwarded to CMake via CMAKE_MODULE_PATH and CMAKE_PREFIX_PATH. See https://cmake.org/cmake/help/latest/command/find_package.html?highlight=find_package for details.
leha-bot
force-pushed
the
feature/github-ci
branch
from
03a07ad to
845575a
Compare
shiz01
approved these changes
Jun 20, 2022
Collaborator
shiz01
left a comment
shiz01
left a comment
There was a problem hiding this comment.
Fine! Next, we will need to add clang to the build matrix.
xvitaly
reviewed
Jun 20, 2022
|
|
||
| env: | ||
| # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.) | ||
| BUILD_TYPE: Release |
Member
There was a problem hiding this comment.
Move BUILD_TYPE, CXX and C from ENV to the cmake configuration step.
Member
Author
There was a problem hiding this comment.
Sounds good, but I'm thinking about env matrix, if it applicable to this case 🤔
| # The CMake configure and build commands are platform agnostic and should work equally well on Windows or Mac. | ||
| # You can convert this to a matrix build if you need cross-platform coverage. | ||
| # See: https://docs.github.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows#using-a-build-matrix | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
I suggest switching to Fedora. Ubuntu LTS has very outdated GCC and Clang versions.
Member
Author
There was a problem hiding this comment.
Agreed, but I'm thinking on compromise decision: make an Ubuntu 22.04, Fedora-latest and some another Windows/macos CI workloads
Member
Author
|
I think that we should go futher, and merge the first revision for the simplest CI checks, and improve it using this PR's feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic build and test running via CMake and CTest.
Closes #2.