Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Waveform analysis examples and class documentation #26

Open
kevinstadler opened this issue Mar 18, 2019 · 8 comments
Open

Add more Waveform analysis examples and class documentation #26

kevinstadler opened this issue Mar 18, 2019 · 8 comments
Milestone

Comments

@kevinstadler
Copy link
Collaborator

With the addition of the Waveform analysis class (see #21 and #22) it would be nice to add another example or two with the same simply waveform visualisation but of different inputs, for example an "OscillatorWaveform" example that's parallel to the "OscillatorSpectrum' one, and also an "AudioInputWaveform" one parallel to the existing "AudioInput" one.

In order for the new class' documentation to show up on the website, the corresponding .xml files also still need to be added to https://github.com/processing/processing-docs/tree/master/content/api_en/LIB_sound

@kevinstadler kevinstadler pinned this issue Mar 18, 2019
@kevinstadler kevinstadler changed the title Add more Waveform analysis examples and class documentation to processing-docs Add more Waveform analysis examples and class documentation Mar 18, 2019
@kevinstadler kevinstadler added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 18, 2019
@mhamilt
Copy link

mhamilt commented Nov 8, 2019

I'm not to familiar with the architecture of processing-docs, but is this just a case of pulling in a file Waveform.xml with the content

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<root>

<name>Waveform</name>

<category>Sound</category>

<subcategory>Analyzer</subcategory>

<usage>Application</usage>

<example>
<image></image>
<code><![CDATA[
import processing.sound.*;

SoundFile sample;
Waveform waveform;

int samples = 100;

public void setup()
{
  size(640, 360);
  background(255);

  sample = new SoundFile(this, "beat.aiff");
  sample.loop();

  waveform = new Waveform(this, samples);
  waveform.input(sample);
}

public void draw()
{
  background(0);
  stroke(255);
  strokeWeight(2);
  noFill();


  waveform.analyze();

  beginShape();
  for(int i = 0; i < samples; i++)
  {
    vertex(
      map(i, 0, samples, 0, width),
      map(waveform.data[i], -1, 1, 0, height)
    );
  }
  endShape();
}
]]></code>
</example>

<description><![CDATA[
  This is a Waveform analyzer. It returns the waveform of the of an audio stream the moment it is queried with the analyze() method.
]]></description>

<syntax>
</syntax>

<parameters>

</parameters>

<method>
<mname>input()</mname>
<mdescription>Define the audio input for the analyzer</mdescription>
</method>

<method>
<mname>analyze()</mname>
<mdescription>Gets the content of the current audiobuffer from the input source, writes it
 into this Waveform's `data` array, and returns it.</mdescription>
</method>

<method>
<mname>stop()</mname>
<mdescription>Stop the analyzer</mdescription>
</method>

<method>
<mname>data</mname>
<mdescription>`float[]` of sample amplitudes between `-1` and `1`</mdescription>
</method>

<constructor>
Waveform(<c>parent</c>)
</constructor>

<cparameter>
<clabel>parent</clabel>
<cdescription>PApplet: typically use "this"</cdescription>
</cparameter>

<returns></returns>

<related>
</related>

<availability>1.0</availability>

<type>Object</type>

<partof>Library</partof>

</root>

@kevinstadler
Copy link
Collaborator Author

That looks great, thanks! Yeah this file should go into processing-docs, and then also just the Java code bit in the examples folder of this repository. I'm working on the next release of the library, so I'll make sure they are included!

@mhamilt
Copy link

mhamilt commented Nov 18, 2019

great!

Seems weird for me to have put .data in <method> tags though.

<method>
<mname>data</mname>
<mdescription>`float[]` of sample amplitudes between `-1` and `1`</mdescription>
</method>

I couldn't find another instance of a class that has documentation of a member variable / class property, not in the format of the sound library xml files that is.

@dhowe
Copy link

dhowe commented Apr 16, 2020

Any progress on this? I still don't see don't see any entry for Waveform in the docs or the javadocs...

see also #21

@kevinstadler
Copy link
Collaborator Author

Added the XML documentation with processing/processing-docs@bdd2a02, just waiting for one of the regular Processing docs rebuilds then it should be online...

@kevinstadler kevinstadler unpinned this issue Apr 13, 2021
@smarbos
Copy link

smarbos commented Jul 27, 2021

Why is this still missing in the documentation?
Can I help somehow?
Thanks!

@kevinstadler
Copy link
Collaborator Author

Hmm not sure why the Waveform page never showed up in the docs, but anyhow the new Processing website (whose documentation is built straight from the JavaDoc instead of the XML files) should be coming out any week now, so not much point fiddling with it now. In the meantime the latest raw JavaDoc documentation for the library is available here: https://processing.github.io/processing-sound/processing/sound/Waveform.html

@smarbos
Copy link

smarbos commented Jul 28, 2021

Thanks a lot @kevinstadler !!

@kevinstadler kevinstadler added documentation and removed enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 21, 2023
@kevinstadler kevinstadler added this to the 2.4.0 milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants