-
-
Notifications
You must be signed in to change notification settings - Fork 8
fixed escaping characters for library.properties #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue should be solved at the contributions level
@Stefterv I agree this should be corrected in the contributions repo, but this i still an issue that should be solved here - the library.properties file should not have escaped colons. |
Hi @mingness we looked into it, and actually the escaped colon is correct according the .properties specification. |
@Stefterv ok, does it break the process if it's not escaped? if not, maybe now's a good time to make it more intuitive? |
@Stefterv actually, which specification are you referring to above? |
The Not escaping |
While there is a Processing standard, I would default to that. I'm not clear what further action is necessary other than merging or not merging. I will leave the decision then to you two. |
I suggest let's not change standards so easily. The library.properties file has till now not required escaping of colons. Of course we can decide to change that based on reasons, such as a java .properties standard, but let's take some time to think about it. Does this file need to be a java standard properties file? Is user readability important? |
No description provided.