Skip to content

fixed escaping characters for library.properties #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vincentsijben
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mingness mingness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@mingness mingness linked an issue May 16, 2025 that may be closed by this pull request
Copy link
Collaborator

@Stefterv Stefterv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue should be solved at the contributions level

@SableRaf SableRaf marked this pull request as draft May 16, 2025 12:41
@mingness
Copy link
Collaborator

@Stefterv I agree this should be corrected in the contributions repo, but this i still an issue that should be solved here - the library.properties file should not have escaped colons.

@mingness mingness requested a review from Stefterv May 16, 2025 12:44
@Stefterv
Copy link
Collaborator

Hi @mingness we looked into it, and actually the escaped colon is correct according the .properties specification.

@mingness
Copy link
Collaborator

@Stefterv ok, does it break the process if it's not escaped? if not, maybe now's a good time to make it more intuitive?

@mingness
Copy link
Collaborator

@Stefterv actually, which specification are you referring to above?
The Processing specification is without the escape: https://github.com/processing/processing4/wiki/Library-Basics#DescribingYourLibrary

@SableRaf
Copy link
Collaborator

SableRaf commented May 16, 2025

The .properties format is defined as part of Java, as described here, where escaping : is technically correct. This is because : can be used interchangeably with =.

Not escaping: doesn't break our pipeline for library.properties files as described in the old Library Basics page (which is probably fine for human-generated properties as it does make it more intuitive) but we should thrive to stick to standards as much as possible when automating things.

@mingness
Copy link
Collaborator

While there is a Processing standard, I would default to that. I'm not clear what further action is necessary other than merging or not merging. I will leave the decision then to you two.

@mingness
Copy link
Collaborator

I suggest let's not change standards so easily. The library.properties file has till now not required escaping of colons. Of course we can decide to change that based on reasons, such as a java .properties standard, but let's take some time to think about it. Does this file need to be a java standard properties file? Is user readability important?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect generated library.properties
4 participants