Skip to content

Use FES internationalization within the minor version #7878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ksen0
Copy link
Member

@ksen0 ksen0 commented Jun 4, 2025

Addresses #7813

const version = '1.11.7';
const loadPath = 'https://cdn.jsdelivr.net/npm/p5@' + version.replace(/^(\d+\.\d+)\.\d+.*$/, '$1') + '/translations/{{lng}}/{{ns}}.json';
console.log(loadPath);
// https://cdn.jsdelivr.net/npm/p5@1.11/translations/{{lng}}/{{ns}}.json
// will become https://cdn.jsdelivr.net/npm/p5@1.11/translations/es/translation.json which exists

@ksen0 ksen0 force-pushed the fes-version branch 3 times, most recently from aa7780b to a8bbc48 Compare June 4, 2025 19:30
@ksen0 ksen0 marked this pull request as ready for review June 4, 2025 19:32
@ksen0 ksen0 requested a review from limzykenneth June 4, 2025 19:32
@ksen0 ksen0 changed the title Use FES internationalization within the minor version [WIP] Use FES internationalization within the minor version Jun 5, 2025
Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took awhile to get to. One suggestion on alternative approach.

@ksen0 ksen0 requested a review from limzykenneth June 10, 2025 18:17
@@ -127,6 +129,7 @@ export let translator = (key, values) => {
* Set up our translation function, with loaded languages
*/
export const initialize = () => {
let latestMinorVersionPath = 'https://cdn.jsdelivr.net/npm/p5@' + constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksen0 , @limzykenneth just a thought here.
Will it be a better idea to separate out the base CDN URL here and the version parsing logic for better readability and reusability too, and then compose the final loadPath. I was thinking to encapsulate it like below:

const getCDNPath = (() => {
  const base = 'https://cdn.jsdelivr.net/npm/p5@';
  const version = constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1');
  return `${base}${version}`;
})();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth to split it out in this way, especially also encapsulating it in a function, if needed, just a string interpolation should suffice as well.

`https://cdn.jsdelivr.net/npm/p5@${constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1')}`

Copy link
Contributor

@IIITM-Jay IIITM-Jay Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that there's no broader scope for reusability in this case, so I agree — using direct string interpolation is sufficient and keeps it clean.

Copy link
Contributor

@IIITM-Jay IIITM-Jay Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial thought was that separating the base URL and version logic might help with readability and clarity, especially if more dynamic paths were ever added later. But given the current usage, simplicity could be more prioritized.

Thanks for sharing this!

@@ -149,8 +152,7 @@ export const initialize = () => {
},
backend: {
fallback: 'en',
loadPath:
'https://cdn.jsdelivr.net/npm/p5/translations/{{lng}}/{{ns}}.json'
loadPath: latestMinorVersionPath + '/translations/{{lng}}/{{ns}}.json'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then here, we could compose it like

loadPath: `${getCDNPath}/translations/{{lng}}/{{ns}}.json`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then I think with string interpolation we could simply write with one liner change:

loadPath: `https://cdn.jsdelivr.net/npm/p5@${constants.VERSION.replace(/^(\d+\.\d+)\.\d+.*$/, '$1')}/translations/{{lng}}/{{ns}}.json`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants