Fix incorrect text weight for variable fonts in Safari #7738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7736
Changes
canvas.style.fontVariationSettingswith the font weight in Safari, as it seems to cache this value incorrectly when setting and resetting this value multiple times per frameisSafaricheck because the old one was returning false on modern SafariScreenshots of the change
This is what this sketch https://editor.p5js.org/davepagurek/sketches/iHyp1r92r looks like in Safari now for me, matching Chrome/Firefox:
https://github.com/user-attachments/assets/b40f2f4c-445e-4c0b-bbc0-16125fd70ed4
PR Checklist
npm run lintpasses