Fix #7259 TypeError for Offscreen Shapes #7626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7259
Fixes "TypeError: Cannot read properties of undefined" when drawing offscreen primitive shapes (
ellipse()
,line()
,rect()
) in p5.js.This error occurs when we change y-coordinate to offscreen value like -1. The error is specific to y-coordinate changes and does not occur with x-coordinate changes.
Error message "Cannot read properties of undefined", pointing to an attempt to access an undefined object.
Changes:
Modify the
_canvasLocator()
inoutputs.js
to returnnull
if a shape’s center is outside the canvas._canvasLocator()
checks if the shape’s center (args[0], args[1]) is within 0 <= args[0] < canvasWidth and 0 <= args[1] < canvasHeight. If not, return null.PR Checklist
npm run lint
passes