Shrink image used for tint tests to speed them up #5773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepagurek
changed the title
stalgiag
approved these changes
Aug 28, 2022
Contributor
stalgiag
left a comment
stalgiag
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! Love the comically tiny version of that image.
Contributor
|
Thanks @davepagurek ! |
1 task
1 task
1 task
This was referenced Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5772
Changes:
I shrunk the image used for tint testing to 25x25 instead of 225x225 to do approximately 1% the number of checks as before. It still tests a few different colors, some of which are fully or partially transparent.
npm run lintpasses