Skip to content

Fixed setHeading() not using the current angle mode #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2022
Merged

Fixed setHeading() not using the current angle mode #5736

merged 1 commit into from
Jul 30, 2022

Conversation

@KevinGrajeda
Copy link
Contributor

@KevinGrajeda KevinGrajeda commented Jul 27, 2022 •
edited
Loading

Resolves #5497

Changes:

  • setHeading now takes into account angleMode(DEGREES)
  • added test for setHeading using radians and degrees

PR Checklist

@KevinGrajeda
Copy link
Contributor Author

KevinGrajeda commented Jul 27, 2022

@limzykenneth, @jeffawang, @AdilRabbani I would like a review, thanks👍.

@KevinGrajeda KevinGrajeda changed the title Fixed setHeading() not using the current angle mode Fixed setHeading(),fromAngle() and random2D() not using the current angle mode Jul 28, 2022
@KevinGrajeda KevinGrajeda marked this pull request as draft July 28, 2022 00:29
@KevinGrajeda KevinGrajeda changed the title Fixed setHeading(),fromAngle() and random2D() not using the current angle mode Fixed setHeading() not using the current angle mode Jul 29, 2022
@KevinGrajeda KevinGrajeda marked this pull request as ready for review July 29, 2022 22:34
@limzykenneth limzykenneth merged commit 11d07e6 into processing:main Jul 30, 2022
@renovate renovate bot mentioned this pull request Oct 18, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Oct 26, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Nov 7, 2022
Merged
1 task
This was referenced Nov 20, 2022
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limzykenneth limzykenneth Awaiting requested review from limzykenneth

@AdilRabbani AdilRabbani Awaiting requested review from AdilRabbani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

p5.Vector.setHeading uses radians, even when angleMode(DEGREES) is specified

2 participants

@KevinGrajeda @limzykenneth