added describe() to all 3d reference examples #5706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page! |
Contributor
Author
|
@kjhollen Moved all describe() calls into setup and now all tests are passing locally! |
kjhollen
approved these changes
Jul 5, 2022
Member
kjhollen
left a comment
kjhollen
left a comment
There was a problem hiding this comment.
Looks good to me! I realize that this commit is just going with what we already have for the alt text. I think some of these could probably be improved, to focus more on what the user would see and less on describing the functionality of the code—let's put some time on your schedule to revisit this summer @aceslowman, as you update the 3D examples.
Member
|
congrats on your first commit @aceslowman!! 🎉 |
Contributor
|
Congrats on your first commit @aceslowman ✨! |
1 task
1 task
1 task
This was referenced Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5705
Changes:
all reference examples for 3d methods now use describe()
PR Checklist
npm run lintpasses