Fixes #5160

[KevinGrajeda]

Changes:

• added return when angleMode() is called without parameters Resolves angleMode not saved/restored by push/pop #5160
• added validation for angleMode() parameters
• added tests and documentation

Screenshots of the change:

PR Checklist

• npm run lint passes
• Inline documentation is included / updated
• Unit tests are included / updated

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

[KevinGrajeda]

@limzykenneth I would like to have a review on this pr, thank you👍

[KevinGrajeda]

added a test for the validation of parameters in anglemode and now i dont have any failed tests

[limzykenneth]

Why is this function made chainable? For most p5.js API there isn't much sense for functions to be chainable as they usually are not exposed as object instance methods.

[KevinGrajeda]

I really don't know the use of chaining in this type of functions i just used other mode functions as a reference:

p5.js/src/core/shape/attributes.js

Lines 139 to 141 in e32b453

	* @method rectMode
	* @param {Constant} mode either CORNER, CORNERS, CENTER, or RADIUS
	* @chainable

p5.js/src/core/shape/attributes.js

Lines 36 to 38 in e32b453

	* @method ellipseMode
	* @param {Constant} mode either CENTER, RADIUS, CORNER, or CORNERS
	* @chainable

p5.js/src/color/setting.js

Lines 241 to 246 in e32b453

	* @method colorMode
	* @param {Constant} mode either RGB, HSB or HSL, corresponding to
	* Red/Green/Blue and Hue/Saturation/Brightness
	* (or Lightness)
	* @param {Number} [max] range for all values
	* @chainable

[limzykenneth]

Can @chainable be removed here? Thanks.

[KevinGrajeda]

I think it's done

[limzykenneth]

I'm not sure how this PR addresses #5160 which has more do to with push() and pop() instead of parameter validation.

[KevinGrajeda]

In #5160 it was mentioned that adding return type to angleMode would be a solution

Adding a return to angleMode() call without argument should be a doable solution.
#5160 (comment)

if this doesn't solve that issue i think it's still useful having that return and the parameter validation was just missing.

[Qianqianye]

Thanks @KevinGrajeda. Hey @limzykenneth, what do you think of the current status of this PR? Thank you!

[limzykenneth]

Looks good. Thanks!

[Qianqianye]

Thanks @KevinGrajeda and @limzykenneth ✨

[Qianqianye]

@all-contributors please add @KevinGrajeda for code

[allcontributors]

@Qianqianye

I've put up a pull request to add @KevinGrajeda! 🎉