Skip to content

fixes issues #5374 and #5504 #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fixes issues #5374 and #5504 #5558

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
979ec94
fixes issues #5374 and #5504
reejuBhattacharya Jan 15, 2022
87c7782
linting changes
reejuBhattacharya Jan 15, 2022
de7de4c
changed string literals to string values
reejuBhattacharya Jan 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/dom/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,11 +772,14 @@ p5.prototype.createSelect = function() {
* assign methods of <a href="#/p5.Element/">p5.Element</a>.
* - `.option(value, [label])` can be used to create a new option for the
* element. If an option with a value already exists, it will be returned.
* It is recommended to use string values as input for `value`.
* Optionally, a label can be provided as second argument for the option.
* - `.remove(value)` can be used to remove an option for the element.
* - `.remove(value)` can be used to remove an option for the element. String
* values recommended as input for `value`.
* - `.value()` method will return the currently selected value.
* - `.selected()` method will return the currently selected input element.
* - `.selected(value)` method will select the option and return it.
* - `.selected(value)` method will select the option and return it. String
* values recommended as input for `value`.
* - `.disable(Boolean)` method will enable/disable the whole radio button element.
*
* @method createRadio
Expand Down Expand Up @@ -809,10 +812,11 @@ p5.prototype.createSelect = function() {
*
* function setup() {
* radio = createRadio();
* radio.option(1, 'apple');
* radio.option(2, 'bread');
* radio.option(3, 'juice');
* radio.option('1', 'apple');
* radio.option('2', 'bread');
* radio.option('3', 'juice');
* radio.style('width', '30px');
* radio.selected('2');
* textAlign(CENTER);
* }
*
Expand Down