Extra files in p5 download?

[tegacodes]

Topic

hey folks, I noticed there are couple of extra files in the zip p5 download. One called p5-test.js and one called p5-pre-min.js. Wondering if these have been left in by accident?

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[limzykenneth]

Yes, those are extra intermediate files generated during the build and probably should have been cleaned up at the end of the build.

[rinkydevi]

hey @limzykenneth i would love to work on this

[limzykenneth]

@rinkydevi Sure, I'll assign the issue to you.

[Qianqianye]

Thanks @tegacodes for pointing it out. I just fixed the zip file in the p5 download for the latest release, so the extra files are no longer in the zip file.

Thanks @limzykenneth for following up with this issue. There have been extra files in the zip file during the last few releases, which we didn’t catch.

@rinkydevi I think the work left to do here is to change the release process in the future to not include these extra files in the zip. I’d suggest looking at https://github.com/processing/p5.js/blob/main/tasks/release/release-p5.js and

p5.js/Gruntfile.js

Lines 361 to 370 in a886238

	// Compresses the lib folder into the release zip archive.
	// Used by the release step.
	compress: {
	main: {
	options: {
	archive: 'release/p5.zip'
	},
	files: [{ cwd: 'lib/', src: ['**/*'], expand: true }]
	}
	},

to get started. Thank you!

[Qianqianye]

Hi @rinkydevi, thanks for your interests in working on this issue. Just want to check in with you to see if you are still available working on this. Otherwise, we can un-assign you to avoid confusion. Thank you!