-
Notifications
You must be signed in to change notification settings - Fork 162
Fix: remove trailing slashes from broken Wikipedia links #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Few unrelated tests (CodeEmbed.test.tsx, CodeFrame.test.tsx) failed due to a known syntax error ( All reference and documentation pages were successfully built and verified locally. |
It looks like your change is to use old versions of two packages. I'm guessing the add-a-slash behavior was introduced in their newer versions? |
Hi @blackboxlogic thank you for the feedback! |
Look at your changed files, note that the first one included two package downgrades. I wonder if you made manual updates to generated files, which I think would be an oops. I'm not familiar with this project, are you? |
@blackboxlogic You're absolutely right, I initially didn't intend to change any dependencies, but I just noticed that I’ve now restored the original versions: This PR only contains content fixes now, with no dependency changes. Thanks again for pointing this out! |
My question remains about if you made manual edits to generated content (removing all the slashes). I suspect the files you edited are the output from an automated process and changing them directly (while easy) is wrong. But I'm not familiar with this project. |
My question remains about if you made manual edits to generated content (removing all the slashes). I suspect the files you edited are the output from an automated process and changing then directly (while easy) is wrong. But I'm not familiar with this project. |
Also acknowledging that you're a stranger on the Internet who is trying to fix a problem and I appreciate that, and maybe you're familiar with this project and your change is correct and I shouldn't be so dismissive. |
Description:
This PR fixes issue #878 by removing unnecessary trailing slashes from Wikipedia links across the p5.js website and documentation. Trailing slashes on some Wikipedia URLs were causing 404 errors.
Issue: Fixes #878
Changes:
Removed trailing slashes from all
wikipedia.org/wiki/
links found using a site-wide search.Example Fixed Link:
Before: https://en.wikipedia.org/wiki/Screen_reader/ (404)
After: https://en.wikipedia.org/wiki/Screen_reader (Works (HTTP 200))
Verification:
http://localhost:4321