Prevent hover state from sticking on mobile accessibility toggles #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
coseeian
reviewed
Nov 5, 2025
| border: 1px solid var(--accent-color); | ||
| background-color: var(--accent-type-color); | ||
| color: var(--accent-color); | ||
| @media (hover: hover) and (pointer: fine) { |
Collaborator
There was a problem hiding this comment.
Please align coding style in this file and fix indention of L23.
| color: var(--accent-color); | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Please remove empty line that is not necessary.
Collaborator
Contributor
Author
|
Thank you for your review @coseeian :) I've fixed the pr as per you comment!!!! |
coseeian
approved these changes
Nov 5, 2025
Collaborator
coseeian
left a comment
coseeian
left a comment
There was a problem hiding this comment.
LGTM, thanks. Let's just wait for p5.js Project Lead to weigh in.
Member
|
Thank you, both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1014
Mobile accessibility options don't visually deselect when untoggled
Changes
@media (hover: hover) and (pointer: fine)to prevent sticky hover states on touch devicessrc/components/Dropdown/styles.module.scssTesting