Delete redundant JSON entries #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukienomiya
added a commit
to yukienomiya/p5.js-website
that referenced
this pull request
Aug 8, 2020
Delete redundant JSON entries (see PR processing#802) Fix classes structure Fix some errors caused by the conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
I deleted some entries from the Reference JSON files (from both es.json and zh-Hans.json).
I believe those lines were redundant as they contained text from static components of the website (such as the menu or the footer) and were therefore already included in the YAML files.
I also updated the index.hbs file accordingly, deleting the swaps relative to those lines, and everything still seems to be working.