Skip to content

Fix bug introduced by translation #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

icarito
Copy link
Contributor

@icarito icarito commented Aug 27, 2022

Fixes bug in score counter.

Changes:
The program was parsing its strings, so translation broke it.

@Qianqianye
Copy link
Contributor

Thanks @icarito. I am adding the Spanish translation stewards @Guirdo, @Andreu-G, @dnd-alv to review this PR.

@Guirdo
Copy link
Contributor

Guirdo commented Aug 28, 2022

Looks fine! 👍

Thanks, @icarito !

@Qianqianye
Copy link
Contributor

Qianqianye commented Aug 28, 2022

Hey @limzykenneth and @montoyamoraga, do you might know any context why the original code is translated as well in this Spanish translation of the example? It seems like most of the other examples in Spanish translation don't have the original code translated.

@montoyamoraga
Copy link
Member

hey @Qianqianye so my guess is that in many examples we translated the comments, to explain the code, but maybe in some like this it made sense too to translate the variable or function names, because they convey a lot of info

i don't remember if we were consistent or not, orif maybe we already have a note about this on the guides for i18n, i hope this helps a bit!

@limzykenneth
Copy link
Member

I'm not sure why in this case the variable names are translated but not in other cases. In general I will probably tend to suggest not translating variable or function names and just translate comments where available. The programming language and p5.js functions are all in English so mixing in another language can be confusing and sometimes problematic (like in this case). How well js engines handle a wider range of Unicode characters in code (except for strings) is also something I have not tried before and can imagine could be very troublesome.

@Qianqianye
Copy link
Contributor

Qianqianye commented Aug 30, 2022

Thanks @limzykenneth and @montoyamoraga for sharing the context. I agree that we should just translate comments where available and not translate variable or function names. I opened a new issue #1270 to address this problem, which include some other examples that have the same issue.
So in this case, I will close this PR. Please continue this conversation in the issue #1270. Thank you!

@Qianqianye Qianqianye closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants