Skip to content

Quick fix to dom-video examples. Fixes #1103 #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

awelles
Copy link

@awelles awelles commented Dec 10, 2021

Fixes #1103

Changes:

Added single noCanvas(); line to setup() in each language's examples/dom-video.html example.

Modified files:

        modified:   src/data/examples/en/16_Dom/08_Video.js
        modified:   src/data/examples/es/16_Dom/08_Video.js
        modified:   src/data/examples/hi/16_Dom/08_Video.js
        modified:   src/data/examples/ko/16_Dom/08_Video.js
        modified:   src/data/examples/zh-Hans/16_Dom/08_Video.js

Single noCanvas(); line added to each:

let button;

function setup() {
 noCanvas();
  // specify multiple formats for different browsers
  fingers = createVideo(['assets/fingers.mov', 'assets/fingers.webm']);
  button = createButton('play');

Buttons are now visible.

Screen Shot 2021-12-09 at 7 08 25 PM

@limzykenneth limzykenneth merged commit 467da4a into processing:main Jan 16, 2022
@limzykenneth
Copy link
Member

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples/dom-video.html - part of video and all of button hidden behind code editor
2 participants