Skip to content

Download latest p5.min.js releases #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Download latest p5.min.js releases #1085

merged 3 commits into from
Oct 8, 2021

Conversation

nickmcintyre
Copy link
Member

Fixes #1084

Changes:

Download latest versions of p5.min.js and p5.sound.min.js when repository_dispatch is triggered using actions-download-file.

Screenshots of the change:

I think this works based on local testing with act.

@nickmcintyre nickmcintyre changed the title Download latest min releases Download latest p5.min.js releases Oct 7, 2021
@outofambit
Copy link
Contributor

i'm good to merge this if you're 👍🏼 , @limzykenneth. we should probably update the current files in src/assets/js manually to fix this in the meantime until the next p5.js release goes out

@limzykenneth
Copy link
Member

@outofambit Yes, those files need to be manually updated for now. @nickmcintyre Do you think you can update them in this PR as well? (Just grab the latest version from the download page or cdnjs) I'll merge it after they are updated here.

@nickmcintyre
Copy link
Member Author

@limzykenneth I just updated the files in the src/assets/js folder. Do we also need to update the gh-pages branch?

@limzykenneth
Copy link
Member

@nickmcintyre Nope, that branch is automatically managed. I'll do a double check then I'll merge this. Thanks!

@limzykenneth limzykenneth merged commit c3d79b7 into processing:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken reference for describe()
3 participants