Fix: mass assignment update project #3875#3893
Open
Nixxx19 wants to merge 3 commits intoprocessing:developfrom
Open
Fix: mass assignment update project #3875#3893Nixxx19 wants to merge 3 commits intoprocessing:developfrom
Nixxx19 wants to merge 3 commits intoprocessing:developfrom
Conversation
Contributor
|
@raclim could you merge the PR? I have verified both the working and the test file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3875
Changes
updateProject(name, files, updatedAt, visibility) souser,slug, etc. can't be overwritten via the request body.userandslugasimmutable: truein the Project schema so ownership and URL can't be changed via updates.updateProject tests (all passing):
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #3875