Fix: GitHub OAuth: use === instead of = in user email matching (#3877)#3892
Merged
raclim merged 1 commit intoprocessing:developfrom Feb 17, 2026
Merged
Conversation
raclim
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3877
Changes
server/config/passport.js(line 180).find()callback when resolving which existing user to link for multiple accounts with the same GitHub emails, changed(u) => (u.email = primaryEmail)to(u) => (u.email === primaryEmail)..find()now correctly returns the user whose email matchesprimaryEmailinstead of the first user, and no longer mutatesu.emailduring iteration, preventing wrong account linking and silent corruption of other users' email fields.Verification
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #3877