Replace “Remove from Collection” button with dropdown in Collection item row#3888
Open
krishnavasnani07 wants to merge 1 commit intoprocessing:developfrom
Open
Replace “Remove from Collection” button with dropdown in Collection item row#3888krishnavasnani07 wants to merge 1 commit intoprocessing:developfrom
krishnavasnani07 wants to merge 1 commit intoprocessing:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3883
Summary
This PR replaces the existing inline “Remove from Collection” button in the collection detail view with a
TableDropdownactions menu.This aligns the collection sketch list UI with existing dropdown patterns used across the editor (e.g., Sketch List and Collection List views), improving clarity and consistency.
Changes
CollectionItemRowwithTableDropdownMenuItemfor “Remove from Collection”removeFromCollection) logic unchangedCollection.RemoveFromCollectionWhy
The previous “X” icon button could be ambiguous regarding its purpose (remove from collection vs delete sketch).
Using a dropdown:
Testing
Verified locally:
npm run lint)npm run typecheck)Screenshots
Before
After