Skip to content

Allow uploading gltf/glb/fbx files #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ojuschugh1
Copy link
Contributor

Fixes #3494

Changes:

I have verified that this pull request:

I've made the following changes to support GLTF, GLB, and FBX file uploads:
Added 'gltf', 'glb', and 'fbx' to the fileExtensionsArray
Added the corresponding MIME types to the mimeTypes string:
model/gltf-binary for GLB files
model/gltf+json for GLTF files
application/x-fbx for FBX files
These changes will allow users to upload GLTF, GLB, and FBX files through the file uploader. The files will be handled by the existing upload infrastructure, which includes:
File size validation (max 5MB per file)
S3 storage for larger files
Local storage for smaller text-based files
Proper MIME type handling

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Jun 27, 2025

Thanks for your work on this @ojuschugh1! After investigating this issue further, I found that it might be coming from the p5.js library, and is not be able to be resolved in the p5.js editor. I think once support for these file formats are in the p5.js library, we can revisit the changes that in this PR. I'm sorry that we weren't able to get this in yet, but can definitely revisit once the file support is setup in the p5.js library!

@raclim raclim closed this Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow uploading gltf/glb/fbx files
2 participants