-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix keyboard navigation for various settings #3474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Jatin24062005 Can you review this PR please. |
@yugalkaushik I’ve reviewed your pull request and tested it on my machine. I noticed a couple of issues: the keyboard navigation currently allows focusing only on enabled buttons, but it should also allow navigation to disabled buttons like Similar to the High Contrast and Dark theme options. Additionally, the focus border appears slightly thicker than the standard one, which creates inconsistency in the UI. Please look into these issues and make the necessary adjustments. |
|
@raclim can you please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your work on this!
After testing this out, I think this is overall a positive change and would be great to have out. We could definitely add any needed adjustments here in the future!
Fixes #3448
Changes:
general.setting.mp4
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123