src button a file icon for a seemless experience. #3363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a beginner-friendly issue and a great starting point for new contributors! @raclim it will be great to label these as 'Good FIrst Issue' Or 'Beginner friendly Issue'
raclim
added
Area: Design
raclim
reviewed
Mar 13, 2025
| @@ -543,14 +541,20 @@ class Editor extends React.Component { | |||
| this.props.closeProjectOptions(); | |||
| }} | |||
| > | |||
| <LeftArrowIcon focusable="false" aria-hidden="true" /> | |||
| <IconButton | |||
| onClick={this.props.expandSidebar} | |||
There was a problem hiding this comment.
I think these lines (544-545) probably aren't needed here, since they're covered by the parent button element right above. If added, the IconButton implementation could probably look more something like: <IconButton focusable="false" aria-hidden="true" />
|
Thanks for giving this a look! After thinking on this, I think we might want to have further discussion on what the final icon design should look like before implementing it. I'm going to close this for now, but left a review on what's here so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the Left and Right Arrow Icons with a Folder Icon, ensuring consistency across different screen sizes. This update aligns the desktop view with the mobile view, making the UI more intuitive and uniform.
Fixes #issue-2888
Changes Made:
✅ Removed the Left and Right Arrow Icons from the sidebar.
✅ Replaced them with the Folder Icon, as seen in the mobile view.
✅ Ensured visual consistency across different screen sizes.
✅ Verified that the new icon behaves as expected and does not break any functionality
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123